Update mapping for new Schwab CSV format #121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, within a couple months of #117 being merged, Schwab changed their CSV format again. On the bright side, it's much easier to parse, as it doesn't have extra lines before and after the header. On the down side, the account ID is no longer in the CSV content, so we can't parse that out anymore.
For what it's worth, the account ID is still provided in the CSV filename, but this PR doesn't attempt to extract it from there.
Commits:
All tests pass locally. I've also been successfully using this to parse downloaded CSV files for several months.